Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: some checks for legal tags/attributes #279

Merged
merged 4 commits into from
Jan 12, 2021
Merged

lint: some checks for legal tags/attributes #279

merged 4 commits into from
Jan 12, 2021

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Dec 24, 2020

  • lint against unrecognized emu- tags
  • lint for use of "oldid" (should be "oldids")

This includes emu-see-also-para as a valid tag because it appears in 262, but ecmarkup doesn't know what that is, so I'm probably just going to remove it from 262 and drop it here. Edit: tc39/ecma262#2271 drops all occurrences of this tag, so it's no longer included here.

@bakkot bakkot mentioned this pull request Jan 12, 2021
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should attr-value point to the position of the value or the attribute? I could see either way.

@bakkot
Copy link
Contributor Author

bakkot commented Jan 12, 2021

attr-value points to the value of the attribute, attr points to the attribute itself. Seemed natural to me.

@bakkot bakkot merged commit 52df46d into master Jan 12, 2021
@bakkot bakkot deleted the lint-emu-tags branch January 12, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants