Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lint for header format #205

Merged
merged 8 commits into from
May 21, 2020
Merged

add lint for header format #205

merged 8 commits into from
May 21, 2020

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented May 20, 2020

@bakkot
Copy link
Contributor Author

bakkot commented May 20, 2020

@michaelficarra addressed comments.


// CreateForInIterator
// Object.fromEntries
// Array.prototype [ @@iterator ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should support Array.prototype [ %Symbol.iterator% ] as well, since we're moving to that form.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer that we disallow it now and make it legal as part of the PR which changes the format, so we are never in a position where both are accepted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's in a different repo. There's a currently open PR. How do you expect that to work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd change it here, bump it, release it, and include the change in the upstream PR as part of the process of merging that PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love it but I'll leave it to @ljharb to fight this fight.

let { line, column } = indexWithinElementToTrueLocation(
getLocation(dom, element),
contents,
name.length
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name.length
name.length - 1,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. It feels kind of weird to point to the e in Example( ), but sure, I guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will also point to the second space in

Example  ( )
though.

@bakkot bakkot merged commit a2b37df into master May 21, 2020
@bakkot bakkot deleted the header-format branch May 21, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants