basic linting behind --lint-spec #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
May 9, 2020
| Statement[${M}a]: \`;\` | ||
| </emu-grammar> | ||
| `, | ||
| "Parameter 'a' is unused." |
There was a problem hiding this comment.
Are these messages being passed through from Grammarkdown's built-in linting? I don't like how its capitalisation and quoting are inconsistent with ours. And I prefer that ours does not change because it's better.
There was a problem hiding this comment.
Should we prefix grammarkdown messages or somehow indicate they came from grammarkdown?
There was a problem hiding this comment.
Ehhh, that doesn't seem like a distinction users are likely to care about.
ljharb
reviewed
May 15, 2020
michaelficarra
approved these changes
May 15, 2020
This was referenced May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements several of the ideas in #173, and hopefully provides a scaffolding which allows contributing more lint rules relatively easily.
Depends on tc39/ecmarkdown#69 being released; marked as a draft until then.Edit: done, ecmarkdown 5.0.1 is released and used in this PR.