Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more robustly locate header #194

Merged
merged 1 commit into from
May 5, 2020
Merged

more robustly locate header #194

merged 1 commit into from
May 5, 2020

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Apr 26, 2020

Fixes tc39/ecma262#1789. See that issue for context.

The querySelector is guaranteed to succeed because every clause is required to have a header.

@bakkot bakkot requested review from ljharb and michaelficarra April 26, 2020 23:32
ljharb
ljharb approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@bakkot bakkot merged commit fd7bc86 into master May 5, 2020
@bakkot bakkot deleted the active-clause branch May 5, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Section 23 does not expand when clicked.
3 participants
@bakkot @ljharb @michaelficarra