Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Refactor Locale and Parameter Negotiation to better align with BCP 47 #871

Merged
merged 8 commits into from
Mar 28, 2024
Merged

Editorial: Refactor Locale and Parameter Negotiation to better align with BCP 47 #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b556aed
Editorial: Introduce dedicated types to clarify locale matching algor…
gibson042 Feb 29, 2024
19479f4
Editorial: Move defaulting logic from {Lookup,BestFit}Matcher into Re…
gibson042 Feb 29, 2024
68c726c
Editorial: Inline BestAvailableLocale into LookupMatcher
gibson042 Feb 29, 2024
d0d0afa
Editorial: Inline {Lookup,BestFit}SupportedLocales into SupportedLocales
gibson042 Mar 1, 2024
b1e2d11
Editorial: Relate ResolveLocale and SupportedLocales to BCP 47 matchi…
gibson042 Mar 1, 2024
fccd112
Editorial: Rename {BestFit,Lookup}Matcher operations to better indica…
gibson042 Mar 1, 2024
6aac79e
Editorial: Rename SupportedLocales to better indicate BCP 47 "filtering"
gibson042 Mar 1, 2024
069c5f3
Editorial: Apply suggestions from code review
gibson042 Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions spec/annexes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ <h1>Implementation Dependent Behaviour</h1>
The set of available locales for each constructor (<emu-xref href="#sec-internal-slots"></emu-xref>)
</li>
<li>
The BestFitMatcher algorithm (<emu-xref href="#sec-bestfitmatcher"></emu-xref>)
</li>
<li>
The BestFitSupportedLocales algorithm (<emu-xref href="#sec-bestfitsupportedlocales"></emu-xref>)
The LookupMatchingLocaleByBestFit algorithm (<emu-xref href="#sec-lookupmatchinglocalebybestfit"></emu-xref>)
</li>
</ul>
</li>
Expand Down
2 changes: 1 addition & 1 deletion spec/collator.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ <h1>Intl.Collator.supportedLocalesOf ( _locales_ [ , _options_ ] )</h1>
<emu-alg>
1. Let _availableLocales_ be %Intl.Collator%.[[AvailableLocales]].
1. Let _requestedLocales_ be ? CanonicalizeLocaleList(_locales_).
1. Return ? SupportedLocales(_availableLocales_, _requestedLocales_, _options_).
1. Return ? FilterLocales(_availableLocales_, _requestedLocales_, _options_).
</emu-alg>
</emu-clause>

Expand Down
2 changes: 1 addition & 1 deletion spec/datetimeformat.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ <h1>Intl.DateTimeFormat.supportedLocalesOf ( _locales_ [ , _options_ ] )</h1>
<emu-alg>
1. Let _availableLocales_ be %Intl.DateTimeFormat%.[[AvailableLocales]].
1. Let _requestedLocales_ be ? CanonicalizeLocaleList(_locales_).
1. Return ? SupportedLocales(_availableLocales_, _requestedLocales_, _options_).
1. Return ? FilterLocales(_availableLocales_, _requestedLocales_, _options_).
</emu-alg>
</emu-clause>

Expand Down
2 changes: 1 addition & 1 deletion spec/displaynames.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ <h1>Intl.DisplayNames.supportedLocalesOf ( _locales_ [ , _options_ ] )</h1>
<emu-alg>
1. Let _availableLocales_ be %Intl.DisplayNames%.[[AvailableLocales]].
1. Let _requestedLocales_ be ? CanonicalizeLocaleList(_locales_).
1. Return ? SupportedLocales(_availableLocales_, _requestedLocales_, _options_).
1. Return ? FilterLocales(_availableLocales_, _requestedLocales_, _options_).
</emu-alg>
</emu-clause>

Expand Down
2 changes: 1 addition & 1 deletion spec/listformat.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ <h1>Intl.ListFormat.supportedLocalesOf ( _locales_ [ , _options_ ] )</h1>
<emu-alg>
1. Let _availableLocales_ be %Intl.ListFormat%.[[AvailableLocales]].
1. Let _requestedLocales_ be ? CanonicalizeLocaleList(_locales_).
1. Return ? SupportedLocales(_availableLocales_, _requestedLocales_, _options_).
1. Return ? FilterLocales(_availableLocales_, _requestedLocales_, _options_).
</emu-alg>
</emu-clause>

Expand Down
6 changes: 3 additions & 3 deletions spec/locale-sensitive-functions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@ <h1>
1. Else,
1. Let _requestedLocale_ be DefaultLocale().
1. Let _noExtensionsLocale_ be the String value that is _requestedLocale_ with any Unicode locale extension sequences removed.
1. Let _availableLocales_ be a List with language tags that includes the languages for which the Unicode Character Database contains language sensitive case mappings. Implementations may add additional language tags if they support case mapping for additional locales.
1. Let _locale_ be BestAvailableLocale(_availableLocales_, _noExtensionsLocale_).
1. If _locale_ is *undefined*, set _locale_ to *"und"*.
1. Let _availableLocales_ be an Available Locales List which includes the language tags for which the Unicode Character Database contains language-sensitive case mappings. If the implementation supports additional locale-sensitive case mappings, _availableLocales_ should also include their corresponding language tags.
1. Let _match_ be LookupMatchingLocaleByPrefix(_availableLocales_, _noExtensionsLocale_).
1. If _match_ is not *undefined*, let _locale_ be _match_.[[locale]]; else let _locale_ be *"und"*.
1. Let _codePoints_ be StringToCodePoints(_S_).
1. If _targetCase_ is ~lower~, then
1. Let _newCodePoints_ be a List whose elements are the result of a lowercase transformation of _codePoints_ according to an implementation-derived algorithm using _locale_ or the Unicode Default Case Conversion algorithm.
Expand Down
174 changes: 63 additions & 111 deletions spec/negotiation.html
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion spec/numberformat.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ <h1>Intl.NumberFormat.supportedLocalesOf ( _locales_ [ , _options_ ] )</h1>
<emu-alg>
1. Let _availableLocales_ be %Intl.NumberFormat%.[[AvailableLocales]].
1. Let _requestedLocales_ be ? CanonicalizeLocaleList(_locales_).
1. Return ? SupportedLocales(_availableLocales_, _requestedLocales_, _options_).
1. Return ? FilterLocales(_availableLocales_, _requestedLocales_, _options_).
</emu-alg>
</emu-clause>

Expand Down
2 changes: 1 addition & 1 deletion spec/pluralrules.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ <h1>Intl.PluralRules.supportedLocalesOf ( _locales_ [ , _options_ ] )</h1>
<emu-alg>
1. Let _availableLocales_ be %Intl.PluralRules%.[[AvailableLocales]].
1. Let _requestedLocales_ be ? CanonicalizeLocaleList(_locales_).
1. Return ? SupportedLocales(_availableLocales_, _requestedLocales_, _options_).
1. Return ? FilterLocales(_availableLocales_, _requestedLocales_, _options_).
</emu-alg>
</emu-clause>

Expand Down
2 changes: 1 addition & 1 deletion spec/relativetimeformat.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ <h1>Intl.RelativeTimeFormat.supportedLocalesOf ( _locales_ [ , _options_ ] )</h1
<emu-alg>
1. Let _availableLocales_ be %Intl.RelativeTimeFormat%.[[AvailableLocales]].
1. Let _requestedLocales_ be ? CanonicalizeLocaleList(_locales_).
1. Return ? SupportedLocales(_availableLocales_, _requestedLocales_, _options_).
1. Return ? FilterLocales(_availableLocales_, _requestedLocales_, _options_).
</emu-alg>
</emu-clause>

Expand Down
2 changes: 1 addition & 1 deletion spec/segmenter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ <h1>Intl.Segmenter.supportedLocalesOf ( _locales_ [ , _options_ ] )</h1>
<emu-alg>
1. Let _availableLocales_ be %Intl.Segmenter%.[[AvailableLocales]].
1. Let _requestedLocales_ be ? CanonicalizeLocaleList(_locales_).
1. Return ? SupportedLocales(_availableLocales_, _requestedLocales_, _options_).
1. Return ? FilterLocales(_availableLocales_, _requestedLocales_, _options_).
</emu-alg>
</emu-clause>

Expand Down
Loading