-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: master is now ES2021 #412
Conversation
This PR can only land after we have the final cut for ES2020 approved and sent as the release candidate |
Please, observe https://github.com/tc39/ecma402/commits/es2019 for the es2020 cut. |
needs updates from #418 |
7cc7318
to
943171e
Compare
rebased |
<p> | ||
Leo Balter<br> | ||
ECMA-402, 8<sup>th</sup> Edition Project Editor | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @spectranaut @isaacdurazo, please let me know if you want to continue the editorship for the 8th Edition (2021) work. I'd be happy to change this.
@@ -264,7 +264,7 @@ <h1>DateTime Format Functions</h1> | |||
<h1>PartitionDateTimePattern ( _dateTimeFormat_, _x_ )</h1> | |||
|
|||
<p> | |||
The PartitionDateTimePattern abstract operation is called with arguments _dateTimeFormat_ (which must be an object initialized as a DateTimeFormat) and _x_ (which must be a Number value), interprets _x_ as a time value as specified in ES2015, <emu-xref href="#sec-time-values-and-time-range"></emu-xref>, and creates the corresponding parts according to the effective locale and the formatting options of _dateTimeFormat_. The following steps are taken: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't this originally specified in ES2015 tho? if the date's just going to be updated, why not call it "ECMA 262" and ignore the year?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the text references to a current value specified. Each new edition invalidates the previous editions so current/parallel edition of ECMAScript has the best accuracy for references.
I agree with renaming it to ECMA-262 or ECMAScript but I'd rather discuss in a separate issue/pr. This PR should be simple enough to just land. If this bit is problematic I'm ok dropping this specific change for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to rebase the PR and this was actually meant to be ES2021 here in this branch.
4e984af
to
4283d9f
Compare
4283d9f
to
53049ac
Compare
No description provided.