Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Adding Intl.Locale specification. #406

Merged
merged 3 commits into from
Feb 26, 2020
Merged

Normative: Adding Intl.Locale specification. #406

merged 3 commits into from
Feb 26, 2020

Conversation

zbraniecki
Copy link
Member

spectranaut
spectranaut requested changes Feb 3, 2020
View reviewed changes
Copy link

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Approved other than minor very editorial changes.

spec/locale.html Outdated Show resolved Hide resolved
spec/locale.html Outdated Show resolved Hide resolved
spec/locales-currencies-tz.html Show resolved Hide resolved
caiolima
caiolima requested changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@caiolima caiolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some editorial issues to be fixed before we merge it. Also, I'm not very familiar with the semantics, so it would be nice if someone with this knowledge could take a look.

spec/locales-currencies-tz.html Show resolved Hide resolved
spec/locale.html Outdated Show resolved Hide resolved
spec/locale.html Outdated Show resolved Hide resolved
spec/locale.html Outdated Show resolved Hide resolved
spec/locales-currencies-tz.html Outdated Show resolved Hide resolved
spec/locales-currencies-tz.html Outdated Show resolved Hide resolved
caiolima
caiolima approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@caiolima caiolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

spectranaut
spectranaut approved these changes Feb 5, 2020
View reviewed changes
Copy link

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@zbraniecki
Copy link
Member Author

Stage 4 has been granted as of February 5th 2020.

@zbraniecki zbraniecki mentioned this pull request Feb 5, 2020
Closed
@anba anba mentioned this pull request Feb 6, 2020
Closed
@leobalter leobalter merged commit 4d1a24a into tc39:master Feb 26, 2020
@Ms2ger Ms2ger mentioned this pull request Feb 27, 2020
Open
@rkirsling rkirsling mentioned this pull request Mar 2, 2020
Merged
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Mar 4, 2020
@sideshowbarker
Locale object now in ECMA402; update spec URLs
3fa52c6 
tc39/ecma402#406 moved the Locale object into
the ECMA402 spec. This change updates the associated BCD spec URLs.

tc39/ecma402@4d1a24a
@sideshowbarker sideshowbarker mentioned this pull request Mar 4, 2020
Merged
Elchi3 pushed a commit to mdn/browser-compat-data that referenced this pull request Mar 4, 2020
@sideshowbarker
Locale object now in ECMA402; update spec URLs (#5778)
d9f2a1f 
tc39/ecma402#406 moved the Locale object into
the ECMA402 spec. This change updates the associated BCD spec URLs.

tc39/ecma402@4d1a24a
@snyk-bot snyk-bot mentioned this pull request Feb 24, 2022
Open
@Manny27nyc Manny27nyc mentioned this pull request Jun 30, 2023
Open
This was referenced Nov 28, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caiolima caiolima caiolima approved these changes

@spectranaut spectranaut spectranaut approved these changes

@leobalter leobalter leobalter approved these changes

@littledan littledan Awaiting requested review from littledan

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zbraniecki @leobalter @spectranaut @caiolima