Normative: use ToIndex instead of ToInteger in ValidateAtomicAccess #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My belief is that this is simply fixing an editorial bug (resulting from changes to TAs happening in parallel with SAB work). Any objections to pulling this? |
|
I'm assuming you're not asking for objections from me, since I opened the PR. Context for Brian's belief: the SAB spec text was written at a time before TypedArray spec algorithms were changed from ToInteger to ToIndex. This instance of ToInteger in ValidateAtomicAccess is a holdover from that. |
|
Needs test cases also. Needs support in implementations. @binji @pizlonator @evilpie Firefox issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1338449 |
bakkot
added
the
needs test262 tests
|
Thanks, Lars. Filed a v8 bug here: https://bugs.chromium.org/p/v8/issues/detail?id=5961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #807