Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: replace non-existent type 'Reference' with type 'Reference Record' and its link #3375

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

denlove
Copy link
Contributor

@denlove denlove commented Jul 23, 2024

I noticed a bug in ECMAScript specification language types. As far as I know, the word Reference used to be the name of the specification type in the past. According to the specification, the word Record has now been added to these types. I added this word, and the link to the Reference Record also became available.

Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an editorial change, not a normative one.

@ljharb ljharb changed the title Normative: replace non-existent type 'Reference' with type 'Reference Record' and its link Editorial: replace non-existent type 'Reference' with type 'Reference Record' and its link Jul 26, 2024
@denlove
Copy link
Contributor Author

denlove commented Jul 26, 2024

Yes, editorial, sorry. I wrote one thing and thought of something else.

@denlove denlove force-pushed the ecma-types branch 2 times, most recently from f4aed7f to 438e4c5 Compare July 26, 2024 19:22
@denlove
Copy link
Contributor Author

denlove commented Jul 26, 2024

@linusg, help me, please.

Unfortunately, after renaming the commit, the first job is stuck and cannot be completed. I used dummy commit to reset the progress, but it didn't help me. I can't stop it with no permissions.

@denlove denlove requested a review from linusg July 26, 2024 19:36
@ljharb
Copy link
Member

ljharb commented Jul 26, 2024

@denlove it's fine, it's just that first-time contributors to repos on github need explicit approval to run workflows.

@denlove
Copy link
Contributor Author

denlove commented Jul 27, 2024

Like I said, job is stuck and cannot be completed. After 6 hours the first job was cancelled.

@ljharb
Copy link
Member

ljharb commented Jul 27, 2024

reran.

@denlove
Copy link
Contributor Author

denlove commented Jul 30, 2024

Thank you for review, Michael.

@denlove

This comment was marked as resolved.

@safinaskar
Copy link

I used dummy commit to reset the progress

Next time just do this: type git commit --amend -a. This command will change timestamp of the last commit. Everything will be the same. Then type git push --force. This is enough to re-run CI. (Note: I'm not contributor to this repo, I'm just a stranger)

@michaelficarra michaelficarra requested a review from a team August 15, 2024 00:14
@denlove
Copy link
Contributor Author

denlove commented Aug 15, 2024

Next time just do this: type git commit --amend -a.

@safinaskar . I gotcha 💯, Аскар.

The truth is that your command is almost my recent dummy commit, just bearded men slang. In my version, it was something like that:

git commit --amend --no-edit

Thank you for your advice. I appreciate it. But for me it didn't work even after re-run CI. You can check the logs above.

P.S. ljharb is the best. Thanks. Just paying my respects.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Sep 2, 2024
@ljharb ljharb merged commit c4f433e into tc39:main Sep 2, 2024
8 checks passed
@ljharb
Copy link
Member

ljharb commented Sep 2, 2024

@denlove oops, forgot a step. would you please register as a contributor?

@denlove
Copy link
Contributor Author

denlove commented Sep 2, 2024

@ljharb Of course. I've already sent you a request.

@ljharb
Copy link
Member

ljharb commented Sep 2, 2024

@denlove thanks :-) unfortunately the "github ID" field needs to be a github username, could you fill it out again?

@denlove
Copy link
Contributor Author

denlove commented Sep 2, 2024

@ljharb Everything is fine?

@ljharb
Copy link
Member

ljharb commented Sep 2, 2024

awesome, yes, thank you!

@denlove denlove deleted the ecma-types branch September 2, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants