-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: replace non-existent type 'Reference' with type 'Reference Record' and its link #3375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an editorial change, not a normative one.
Yes, editorial, sorry. I wrote one thing and thought of something else. |
f4aed7f
to
438e4c5
Compare
@linusg, help me, please. Unfortunately, after renaming the commit, the first job is stuck and cannot be completed. I used dummy commit to reset the progress, but it didn't help me. I can't stop it with no permissions. |
@denlove it's fine, it's just that first-time contributors to repos on github need explicit approval to run workflows. |
Like I said, job is stuck and cannot be completed. After 6 hours the first job was cancelled. |
reran. |
Thank you for review, Michael. |
This comment was marked as resolved.
This comment was marked as resolved.
Next time just do this: type |
@safinaskar . I gotcha 💯, Аскар.The truth is that your command is almost my recent dummy commit, just bearded men slang. In my version, it was something like that: git commit --amend --no-edit Thank you for your advice. I appreciate it. But for me it didn't work even after re-run CI. You can check the logs above. P.S. ljharb is the best. Thanks. Just paying my respects. |
… Record' and its link (tc39#3375)
@denlove oops, forgot a step. would you please register as a contributor? |
@ljharb Of course. I've already sent you a request. |
@denlove thanks :-) unfortunately the "github ID" field needs to be a github username, could you fill it out again? |
@ljharb Everything is fine? |
awesome, yes, thank you! |
I noticed a bug in ECMAScript specification language types. As far as I know, the word
Reference
used to be the name of the specification type in the past. According to the specification, the wordRecord
has now been added to these types. I added this word, and the link to the Reference Record also became available.