More tweaks for the iterator handling AOs

[bakkot]

The iterator protocol has a bunch of helper AOs. But almost everything just uses IteratorStepValue (introduced in #3268) and IteratorClose; the exceptions are

• IteratorStep still gets used when you need to iterate but don't care about the value - specifically, it gets used for [foo, , bar] = baz destructurings with elisions, and in some of the iterator helper proposals (e.g. .drop), which will need updating.
• IteratorNext gets used in %AsyncFromSyncIteratorPrototype%.next (the thing which handles for await over a sync iterator)
• IteratorComplete and IteratorValue get used in for of and yield * so that they can share logic between sync vs async iteration, plus in %AsyncFromSyncIteratorPrototype.

This PR changes IteratorStep and IteratorNext so that they set the [[Done]] slot on the Iterator Record to true when some part of the protocol throws or the iterator result object's .done is found to be true, consistent with how IteratorStepValue behaves. (I'd previously considered eliminating IteratorStep entirely, but "I need to advance this iterator but I don't care about the value" is a coherent thing and does come up sometimes.)

Of the above uses, only the "destructurings with elisions" case actually care whether the [[Done]] slot gets set to true, which it was previously doing explicitly. Still, it seems nicer to handle these uniformly, such that manipulation of that slot is done only in the iterator AOs themselves.

This also incidentally eliminates 2 of the remaining 4 explicit uses of the ReturnIfAbrupt macro (cf #1573 (comment)), the last two being in [[Call]] and [[Construct]] for ECMAScript function objects.

[syg]

I like it.

Drive-by: looking at the description for [[Done]], I don't really like "Whether the iterator has been closed". It almost reads to me as whether IteratorClose has been called on it. I don't have a better suggestion at the moment though, I think I just narrowly don't like the word "closed" here.

[bakkot]

Maybe "Whether the iterator has completed or been closed"?

[syg]

Maybe "Whether the iterator has completed or been closed"?

sgtm!