Editorial: avoid multiple declarations of an alias #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Jan 30, 2024
bakkot
added
the
ready to merge
ljharb
force-pushed
the
iterator-step-value
branch
from
6ed5639 to
12d3687
Compare
ljharb
force-pushed
the
IteratorDestructuringAssignmentEvaluation
branch
from
e46362e to
6d7aa1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where we can reach the declaration of
valuenot-exactly-once. That is in editorial issue. Fixed using the pattern we already use in many other places, often with the aliasv.Done on top of #3268 as to not conflict. Marking as draft until that is merged.