Meta: Redirect to HTTPS #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures people are browsing https://tc39.github.io/ecma262/ rather than its HTTP counterpart. Since GitHub Pages doesn’t offer HSTS or proper redirects yet, this is the best we can do.
| @@ -4,6 +4,11 @@ | |||
| <link href="ecmarkup.css" rel="stylesheet"> | |||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/8.4/styles/github.min.css"> | |||
| <script src="ecmarkup.js"></script> | |||
| <script> | |||
| if (location.hostname === 'tc39.github.io' && location.protocol !== 'https:') { | |||
There was a problem hiding this comment.
any reason to even check the hostname?
There was a problem hiding this comment.
So that it can still be tested locally, e.g. on http://localhost/.
|
Committed as 59fca32. Thanks! |
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This “ensures” people are browsing https://tc39.github.io/ecma262/ rather than its HTTP counterpart.
Since GitHub Pages doesn’t offer HSTS or proper redirects yet, this is the best we can do.