Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: remove unused capture in %TypedArray%.prototype.sort #2836

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Editorial: remove unused capture in %TypedArray%.prototype.sort #2836

merged 1 commit into from
Jul 24, 2022

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Jul 22, 2022

When the detached check was removed this seems to have been left behind.

bakkot
bakkot approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, cf #2723

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jul 22, 2022
@bakkot bakkot mentioned this pull request Jul 22, 2022
Open
@ljharb ljharb force-pushed the useless-capture branch from efe8cda to 70baf25 Compare July 24, 2022 19:28
@ljharb ljharb merged commit 70baf25 into tc39:main Jul 24, 2022
@devsnek devsnek deleted the useless-capture branch July 24, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devsnek @syg @michaelficarra @bakkot @ljharb