Proxy [[Enumerate]]: exhaust iterator and throw on non-strings. #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 1. If _next_ is *false*, return CreateArrayIterator(_array_, `"value"`). | ||
| 1. Let _nextValue_ be ? IteratorValue(_next_). | ||
| 1. If Type(_nextValue_) is not String, throw a *TypeError* exception. | ||
| 1. Let _status_ be ? CreateDataProperty(_array_, ToString(ToUint32(_nextIndex_)), _nextValue_). |
There was a problem hiding this comment.
Since CreateDataProperty can't throw, I'd say replace ? with !. It might also be more clear to say: Perform ! CreateDataPropertyOrThrow... and remove the next line.
|
Also, if you are not a TC39 member, please follow the guidelines at the bottom of the contributing.md file (namely, fill this out: http://www.ecma-international.org/memento/register_TC39_Royalty_Free_Task_Group.php) |
|
Talked to @littledan and I also see your @ chromium email address. You're covered, no need to sign that form. Thanks! |
GeorgNeis
force-pushed
the
proxy-enumerate
branch
from
99fb0f5 to
683120d
Compare
|
Thanks for the feedback. I made the suggested change. |
|
Looks good, thanks! |
|
Committed as 26aabf6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
#160
#161