Editorial: Eliminate 'bare' uses of "completion" #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
reviewed
Mar 4, 2022
| @@ -47823,7 +47821,7 @@ <h1>Additions and Changes That Introduce Incompatibilities with Prior Editions</ | |||
| <p><emu-xref href="#sec-assignment-operators-static-semantics-early-errors"></emu-xref>: In ECMAScript 2015, strict mode code containing an assignment to an immutable binding such as the function name of a |FunctionExpression| does not produce an early error. Instead it produces a runtime error.</p> | |||
| <p><emu-xref href="#sec-block"></emu-xref>: In ECMAScript 2015, a |StatementList| beginning with the token let followed by the input elements |LineTerminator| then |Identifier| is the start of a |LexicalDeclaration|. In previous editions, automatic semicolon insertion would always insert a semicolon before the |Identifier| input element.</p> | |||
| <p><emu-xref href="#sec-expression-statement"></emu-xref>: In ECMAScript 2015, a |StatementListItem| beginning with the token `let` followed by the token `[` is the start of a |LexicalDeclaration|. In previous editions such a sequence would be the start of an |ExpressionStatement|.</p> | |||
| <p><emu-xref href="#sec-if-statement-runtime-semantics-evaluation"></emu-xref>: In ECMAScript 2015, the normal completion value of an |IfStatement| is never the value ~empty~. If no |Statement| part is evaluated or if the evaluated |Statement| part produces a normal completion whose value is ~empty~, the completion value of the |IfStatement| is *undefined*.</p> | |||
| <p><emu-xref href="#sec-if-statement-runtime-semantics-evaluation"></emu-xref>: In ECMAScript 2015, the normal result of an |IfStatement| is never the value ~empty~. If no |Statement| part is evaluated or if the evaluated |Statement| part produces a normal completion containing ~empty~, the result of the |IfStatement| is *undefined*.</p> | |||
There was a problem hiding this comment.
This is a little ambiguous, in the way that "normally containing" was ambiguous in the first draft of #2547, but since this is just non-normative exposition I'm fine with it.
There was a problem hiding this comment.
Yup, that's roughly how I felt about it too.
bakkot
approved these changes
Mar 4, 2022
michaelficarra
approved these changes
Mar 8, 2022
bakkot
added
the
ready to merge
(2 uses of "completion" and 8 uses of "completion value")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... i.e., uses of "completion" that aren't preceded by "normal", "abrupt", "throw", etc., and aren't just using it in its usual English sense. This includes 8 occurrences of "completion value".
I left the 'Meaning' for
[[Type]]("The type of completion that occurred") as it's maybe the usual English sense. (A Completion Record doesn't "occur".) It's debatable though.I handled the occurrences of "completion value" in various ways, depending on the context.
In cleaning up "completion value" in the description of HostImportModuleDynamically, I merged 2 list items, which is a bit surprising, so look at that one carefully.
In the Annex F cases of "completion value", I also changed 3 occurrences of
a normal completion whose value is ~empty~toa normal completion containing ~empty~.This is a follow-up to #2547, prompted by this discussion.