Editorial: Use consistent phrasing for parameters that are Number or BigInt #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Jan 13, 2022
|
I introduce a few of these in #2547 (I add a ton of explicit AO return types). Can we hold off on merging this until we have an ecmarkup lint rule enforcing it so I don't just re-introduce these? |
syg
approved these changes
Jan 19, 2022
michaelficarra
added
the
ready to merge
ljharb
force-pushed
the
2022-01-phrasing-consistency
branch
from
f8f0103 to
8e64031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, NumericToRawBytes is the odd one out (it uses "a BigInt or a Number" while SameValueNonNumeric and SetValueInBuffer and GetModifySetValueInBuffer all use "a Number or a BigInt").