-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify ToIndex, ToLength, and ToIntegerOrInfinity #2501
Merged
ljharb
merged 3 commits into
tc39:master
from
gibson042:2021-08-refactor-index-conversion
Sep 22, 2021
Merged
Clarify ToIndex, ToLength, and ToIntegerOrInfinity #2501
ljharb
merged 3 commits into
tc39:master
from
gibson042:2021-08-refactor-index-conversion
Sep 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
force-pushed
the
2021-08-refactor-index-conversion
branch
from
August 27, 2021 16:38
89dca12
to
f128a82
Compare
michaelficarra
approved these changes
Aug 27, 2021
bakkot
reviewed
Aug 27, 2021
bakkot
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM with my suggested change applied.
michaelficarra
added
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
and removed
editor call
to be discussed in the next editor call
labels
Sep 22, 2021
ljharb
force-pushed
the
2021-08-refactor-index-conversion
branch
from
September 22, 2021 21:40
ee0b775
to
1822f37
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.