Editorial: Validate array length using SameValueZero in ArraySetLength and Array
#2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
reviewed
Jul 16, 2021
|
A quick question - 23.1.1.1's step |
|
Since |
pacokwon
force-pushed
the
array-length-same-value
branch
from
f6d3266 to
58a0c1c
Compare
pacokwon
changed the title
ArraySetLengthSameValue in ArraySetLength and Array
|
Of course. I've applied the changes and updated the PR, let me know what you think! |
bakkot
changed the title
SameValue in ArraySetLength and ArraySameValueZero in ArraySetLength and Array
bakkot
approved these changes
Jul 17, 2021
pacokwon
added a commit
to kaist-plrg/jiset
that referenced
this pull request
Jul 19, 2021
michaelficarra
approved these changes
Jul 19, 2021
bakkot
added
the
ready to merge
ljharb
force-pushed
the
array-length-same-value
branch
from
58a0c1c to
ee2d790
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that the
≠(≠) notation should be used when comparing array lengths in 10.4.2.4 ArraySetLength's step5.According to test262/test/built-ins/Object/defineProperties/15.2.3.7-6-a-127.js, a
RangeErrormust not be thrown, meaning thatnewLenandnumberLen, which are0and-0.0in this case, should be "the same value".From what I've seen in #1963 and one of the discussions when the phrase "the same value" was first introduced, the likes of
=,≠seem to be used for mathematical equality, which is what I think is a more suitable notation to express the comparison.