Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Define+use list-concatenation #2382

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Apr 11, 2021

It's analogous to string-concatenation.

I've made separate commits for ease of reviewing. You could squash them all except perhaps the last.

@jmdyck
Copy link
Collaborator Author

jmdyck commented May 13, 2021

(force-pushed to rebase to master, and handle a couple cases added by #1668)

@ljharb ljharb force-pushed the master branch 3 times, most recently from 3d0c24c to 7a79833 Compare June 29, 2021 02:21
@bakkot bakkot added the editor call to be discussed in the next editor call label Jul 5, 2021
@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Jul 7, 2021
spec.html Outdated Show resolved Hide resolved
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In cases where we are introducing new numbered aliases, I would prefer we number the first one as well (as in, names1) to better convey that it is just another part, not the whole. LGTM otherwise.

@jmdyck
Copy link
Collaborator Author

jmdyck commented Jul 8, 2021

In cases where we are introducing new numbered aliases, I would prefer we number the first one as well (as in, names1) ...

That'd be my preference as well, but I left it out to minimize the diff.

@jmdyck jmdyck force-pushed the list-concatenation branch from d68dfa1 to 5dab024 Compare July 8, 2021 15:06
@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jul 8, 2021
@ljharb ljharb force-pushed the list-concatenation branch from 5dab024 to af5467d Compare July 10, 2021 20:46
@ljharb ljharb merged commit af5467d into tc39:master Jul 10, 2021
@jmdyck jmdyck deleted the list-concatenation branch July 10, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants