-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Define+use list-concatenation
#2382
Conversation
a46dfbe
to
d68dfa1
Compare
(force-pushed to rebase to master, and handle a couple cases added by #1668) |
3d0c24c
to
7a79833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In cases where we are introducing new numbered aliases, I would prefer we number the first one as well (as in, names1
) to better convey that it is just another part, not the whole. LGTM otherwise.
That'd be my preference as well, but I left it out to minimize the diff. |
d68dfa1
to
5dab024
Compare
5dab024
to
af5467d
Compare
It's analogous to
string-concatenation
.I've made separate commits for ease of reviewing. You could squash them all except perhaps the last.