Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Define Module Namespace's [[GetPrototypeOf]] method #2335

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Editorial: Define Module Namespace's [[GetPrototypeOf]] method #2335

merged 1 commit into from
Sep 22, 2021

Conversation

shvaikalesh
Copy link
Member

Module Namespace's [[GetPrototypeOf]] method, introduced in ES6, was replaced with a [[Prototype]] slot in #748 because SetImmutablePrototype didn't call [[GetPrototypeOf]] at the time (fixed in #841).

This change makes definition of Module Namespace's prototype consistent with its definition of (non-)extensibility.
AWB argued for this approach in #858 (comment).

@ljharb ljharb requested review from syg, michaelficarra, bakkot and a team March 1, 2021 15:02
syg
syg approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me to use the internal methods instead of directly accessing slots, if the reasons for the original workaround are now fixed.

@ljharb ljharb force-pushed the master branch 3 times, most recently from 3d0c24c to 7a79833 Compare June 29, 2021 02:21
@bakkot bakkot force-pushed the module-namespace-add-getprototypeof-method branch from 831e12e to 92d5696 Compare September 22, 2021 21:43
bakkot
bakkot approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased. LGTM.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Sep 22, 2021
@ljharb ljharb force-pushed the module-namespace-add-getprototypeof-method branch from 92d5696 to b3c9c3d Compare September 22, 2021 21:48
@ljharb ljharb merged commit b3c9c3d into tc39:master Sep 22, 2021
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
@shvaikalesh @mathiasbynens
Editorial: Define Module Namespace's [[GetPrototypeOf]] method (tc39#…
642fbde 
…2335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@syg syg syg approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shvaikalesh @ljharb @syg @michaelficarra @bakkot