Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: reword StringIndexOf in terms of substring #2258

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Editorial: reword StringIndexOf in terms of substring #2258

merged 1 commit into from
Jan 6, 2021

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Dec 26, 2020

This is a very small tweak. I find the explicit loop to be easier to understand than the previous "if there exists ... such that for all ..." prose.

ljharb
ljharb approved these changes Dec 26, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive improvement, thanks

@ljharb ljharb requested review from syg, michaelficarra and a team December 26, 2020 05:20
mathiasbynens
mathiasbynens approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although git blame points to me here, this was inherited from the old phrasing (from before StringIndexOf existed). I agree this patch makes things much easier to follow!

@ljharb
Copy link
Member

ljharb commented Dec 28, 2020

(added in #2009; i commented on this here :-p )

syg
syg approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@ljharb ljharb added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jan 6, 2021
@ljharb ljharb force-pushed the reword-stringindexof branch from dfa8c90 to e656451 Compare January 6, 2021 22:24
@ljharb ljharb merged commit e656451 into master Jan 6, 2021
@ljharb ljharb deleted the reword-stringindexof branch January 6, 2021 22:42
@bakkot bakkot mentioned this pull request Mar 1, 2021
Merged
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 28, 2021
@ljharb
Editorial: String.prototype.lastIndexOf: use explicit algorithm steps
f341e49 
See also, tc39#2258
@ljharb ljharb mentioned this pull request Sep 28, 2021
Merged
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 28, 2021
@ljharb
Editorial: String.prototype.lastIndexOf: use explicit algorithm ste…
5309eba 
…ps (tc39#2536)

See also, tc39#2258
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 28, 2021
@ljharb
Editorial: String.prototype.lastIndexOf: use explicit algorithm ste…
1daf993 
…ps (tc39#2536)

See also, tc39#2258
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 28, 2021
@ljharb
Editorial: String.prototype.lastIndexOf: use explicit algorithm ste…
68e31a0 
…ps (tc39#2536)

See also, tc39#2258
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 28, 2021
@ljharb
Editorial: String.prototype.lastIndexOf: use explicit algorithm ste…
45da3ee 
…ps (tc39#2536)

See also, tc39#2258
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 28, 2021
@ljharb
Editorial: String.prototype.lastIndexOf: use explicit algorithm ste…
cd5c808 
…ps (tc39#2536)

See also, tc39#2258
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 28, 2021
@ljharb
Editorial: String.prototype.lastIndexOf: use explicit algorithm ste…
c5cc36a 
…ps (tc39#2536)

See also, tc39#2258
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 28, 2021
@ljharb
Editorial: String.prototype.lastIndexOf: use explicit algorithm ste…
59b7485 
…ps (tc39#2536)

See also, tc39#2258
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
@ljharb @mathiasbynens
Editorial: String.prototype.lastIndexOf: use explicit algorithm ste…
de9fb5d 
…ps (tc39#2536)

See also, tc39#2258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syg syg syg approved these changes

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@ljharb ljharb ljharb approved these changes

@michaelficarra michaelficarra Awaiting requested review from michaelficarra

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bakkot @ljharb @mathiasbynens @syg