Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Standardize preambles for host-defined abstract operations #2253

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Dec 13, 2020

... using the format established in PR #1914.

spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than stray commas.

@jmdyck
Copy link
Collaborator Author

jmdyck commented Jan 16, 2021

(force-pushed to resolve merge conflicts)

spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@ljharb ljharb added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Feb 12, 2021
@ljharb ljharb merged commit 28213d7 into tc39:master Feb 12, 2021
@jmdyck jmdyck deleted the preambles branch February 12, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants