Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Fix bug in Annex B defn of AtomEscape #2235

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Editorial: Fix bug in Annex B defn of AtomEscape #2235

merged 1 commit into from
Dec 2, 2020

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Nov 29, 2020

Specifically, change:

AtomEscape[U, N] :: CharacterEscape[~U, ?N]

to:

AtomEscape[U, N] :: CharacterEscape[?U, ?N]

This fixes a bug that PR #403 introduced way back in 2016.

Resolves issue #1672 (which see for some discussion).

@jmdyck
Copy link
Collaborator Author

jmdyck commented Nov 29, 2020

Normally, changing the grammar like this would be a normative change. However, I've marked this PR as Editorial because:
(a) Annex B guarantees that it doesn't change any [+U] syntax, so the original bug left the spec in an inconsistent state on this point, and
(b) apparently (see here), engines resolve the inconsistency in favor of the guarantee, i.e. as if this PR were applied.

@ljharb ljharb requested review from michaelficarra and syg November 29, 2020 06:23
syg
syg approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice sleuthing for what introduced the bug

@ljharb ljharb self-assigned this Dec 1, 2020
@jmdyck @ljharb
Editorial: Fix bug in Annex B defn of AtomEscape (tc39#2235)
3db2f0d 
Specifically, change:
    AtomEscape[U, N] :: CharacterEscape[~U, ?N]
to:
    AtomEscape[U, N] :: CharacterEscape[?U, ?N]

This fixes a bug that PR tc39#403 introduced way back in 2016.

Resolves issue tc39#1672 (which see for some discussion).
@ljharb ljharb force-pushed the fix_annex_b_AtomEscape branch from 860ebf5 to 3db2f0d Compare December 2, 2020 06:23
@ljharb ljharb merged commit 3db2f0d into tc39:master Dec 2, 2020
@bakkot bakkot mentioned this pull request Dec 2, 2020
Closed
@jmdyck jmdyck deleted the fix_annex_b_AtomEscape branch December 2, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

Assignees

@ljharb ljharb

Labels
editorial change spec bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmdyck @syg @michaelficarra @bakkot @ljharb