Normative: IsDetachedBuffer should be checked before accessing [[ArrayLength]] #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Oct 17, 2020
rkirsling
changed the title
rkirsling
changed the title
|
Added a commit to address #2164 (comment) and temporarily removed |
rkirsling
force-pushed
the
isdetachedbuffer-before-isvalidintegerindex
branch
from
6d1e652 to
f744988
Compare
syg
approved these changes
Oct 20, 2020
michaelficarra
approved these changes
Oct 20, 2020
ljharb
added
editorial change
spec bug
normative change
|
Per editor call: let's call this normative, but we'll land it without consensus on the belief that it was intended to be a part of #2164. @rkirsling we also think it makes sense to move move the |
|
Done. Thanks for your patience. 🙇 |
rkirsling
changed the title
ljharb
added
the
ready to merge
ljharb
force-pushed
the
isdetachedbuffer-before-isvalidintegerindex
branch
from
864a25d to
7ea0ac9
Compare
jugglinmike
added a commit
to bocoup/proposal-resizablearraybuffer
that referenced
this pull request
Jun 12, 2021
A recent change to ECMA262 inserted an invocation of IsDetachedBuffer into the modified algorithm. Update the proposal to accommodate that change and more faithfully describe the change will which take place when the proposal is merged. [1] tc39/ecma262#2207
syg
pushed a commit
to tc39/proposal-resizablearraybuffer
that referenced
this pull request
Jun 16, 2021
A recent change to ECMA262 inserted an invocation of IsDetachedBuffer into the modified algorithm. Update the proposal to accommodate that change and more faithfully describe the change will which take place when the proposal is merged. [1] tc39/ecma262#2207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably wrong to call this editorial, but it's a fix for an oversight in #2164.
Integer-indexed [[DefineOwnProperty]] is the only place where IsValidIntegerIndex is checked without being immediately preceded by an IsDetachedBuffer check, and I believe this to be a mistake.
The issue is that IsValidIntegerIndex checks [[ArrayLength]] of the typed array itself, which is unaffected by calling DetachArrayBuffer. This seems very silly and may warrant a more significant refactor, but the immediate fix is to avoid calling IsValidIntegerIndex on a typed array with a detached buffer.