-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Arbitrary module namespace identifier names #2154
Merged
ljharb
merged 1 commit into
tc39:main
from
bmeck:arbitrary-module-namespace-identifier-names
Nov 10, 2021
Merged
Normative: Arbitrary module namespace identifier names #2154
ljharb
merged 1 commit into
tc39:main
from
bmeck:arbitrary-module-namespace-identifier-names
Nov 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeck
added
needs consensus
This needs committee consensus before it can be eligible to be merged.
needs test262 tests
The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262
normative change
Affects behavior required to correctly evaluate some ECMAScript source text
labels
Aug 26, 2020
ljharb
changed the title
Arbitrary module namespace identifier names
Normative: Arbitrary module namespace identifier names
Aug 26, 2020
ljharb
reviewed
Aug 26, 2020
devsnek
reviewed
Aug 26, 2020
devsnek
reviewed
Aug 26, 2020
ljharb
pushed a commit
to ljharb/ecma262
that referenced
this pull request
Aug 26, 2020
This was extracted from tc39#2154 so it could land separately.
ljharb
pushed a commit
to ljharb/ecma262
that referenced
this pull request
Aug 26, 2020
This was extracted from tc39#2154 so it could land separately.
devsnek
reviewed
Aug 26, 2020
spec.html
Outdated
1. Let _env_ be the running execution context's LexicalEnvironment. | ||
1. Perform ? InitializeBoundName(*"\*default\*"*, _value_, _env_). | ||
1. Perform ? InitializeBoundName(~default~, _value_, _env_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InitializeBoundName
only accepts strings
ljharb
pushed a commit
to ljharb/ecma262
that referenced
this pull request
Aug 26, 2020
This was extracted from tc39#2154 so it could land separately.
ljharb
pushed a commit
to ljharb/ecma262
that referenced
this pull request
Aug 26, 2020
This was extracted from tc39#2154 so it could land separately.
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Aug 26, 2020
This was extracted from tc39#2154 so it could land separately. Co-authored-by: Jordan Harband <[email protected]>
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Sep 2, 2020
This was extracted from tc39#2154 so it could land separately. Co-authored-by: Jordan Harband <[email protected]>
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Sep 2, 2020
This was extracted from tc39#2154 so it could land separately. Co-authored-by: Jordan Harband <[email protected]>
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Sep 2, 2020
This was extracted from tc39#2154 so it could land separately. Co-authored-by: Jordan Harband <[email protected]>
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Sep 2, 2020
This was extracted from tc39#2154 so it could land separately. Co-authored-by: Jordan Harband <[email protected]>
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Sep 8, 2020
This was extracted from tc39#2154 so it could land separately. Co-authored-by: Jordan Harband <[email protected]>
Updated, now depends on #2155 |
5 tasks
bakkot
reviewed
Sep 21, 2020
bakkot
reviewed
Sep 21, 2020
bakkot
reviewed
Sep 21, 2020
ljharb
added
has consensus
This has committee consensus.
and removed
needs consensus
This needs committee consensus before it can be eligible to be merged.
labels
Sep 21, 2020
gibson042
reviewed
Sep 21, 2020
Should we allow The goal example import {"\0 any unicode" as foo} from "";
export {foo as "\0 any unicode"}; reminds me of the following one-liner: export {"\0 any unicode" as "\0 any unicode"} from "some-module"; |
It should also be possible to do: export { "\0 any unicode" } from "some-module"; |
1 task
sxzz
added a commit
to vuejs/core
that referenced
this pull request
Dec 29, 2022
5 tasks
sxzz
added a commit
to vuejs/core
that referenced
this pull request
Jan 26, 2023
sxzz
added a commit
to vuejs/core
that referenced
this pull request
Feb 1, 2023
sxzz
added a commit
to vuejs/core
that referenced
this pull request
Feb 4, 2023
sxzz
added a commit
to vuejs/core
that referenced
this pull request
Mar 27, 2023
sxzz
added a commit
to vuejs/core
that referenced
this pull request
Mar 28, 2023
sxzz
added a commit
to vuejs/core
that referenced
this pull request
Mar 28, 2023
yyx990803
pushed a commit
to vuejs/core
that referenced
this pull request
Mar 28, 2023
IAmSSH
pushed a commit
to IAmSSH/core
that referenced
this pull request
May 14, 2023
5 tasks
4 tasks
6 tasks
9 tasks
3 tasks
This was referenced May 24, 2024
7 tasks
This was referenced Sep 10, 2024
rhysd
added a commit
to rhysd/yats.vim
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has consensus
This has committee consensus.
has test262 tests
normative change
Affects behavior required to correctly evaluate some ECMAScript source text
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not believe this affects any integration downstream.
This PR aims to allow:
This matches the restriction that WASM has that the string names for exports must be valid Unicode.
Depends on #2155