Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: reference correct nonterminals in IteratorDestructuringAssignmentEvaluation #2121

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Aug 1, 2020

The referenced nonterminals don't exist. This was changed in #2030, presumably by accident (cc @jridgewell), and this PR puts it back (while keeping the tweaked wording @michaelficarra preferred).

Thanks to @devsnek for spotting it.

@bakkot bakkot added the spec bug label Aug 1, 2020
@jridgewell
Copy link
Member

Ha, I think I replaced all instances of NamedEvaluation. This is indeed unintentional.

@ljharb ljharb requested a review from syg August 3, 2020 16:32
@ljharb ljharb self-assigned this Aug 3, 2020
@ljharb ljharb force-pushed the iterator-named-eval branch from 5c68c29 to cb3a24d Compare August 6, 2020 04:29
@ljharb ljharb merged commit cb3a24d into master Aug 6, 2020
@ljharb ljharb deleted the iterator-named-eval branch August 6, 2020 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants