Editorial: quick fixes #2022
Merged
Editorial: quick fixes #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
May 29, 2020
bakkot
approved these changes
May 29, 2020
spec.html
Outdated
| @@ -13156,7 +13156,7 @@ <h1>Runtime Semantics: GetTemplateObject ( _templateLiteral_ )</h1> | |||
| 1. Let _index_ be 0. | |||
| 1. Repeat, while _index_ < _count_, | |||
| 1. Let _prop_ be ! ToString(_index_). | |||
| 1. Let _cookedValue_ be the String value _cookedStrings_[_index_]. | |||
| 1. Let _cookedValue_ be _cookedStrings_[_index_]. | |||
There was a problem hiding this comment.
For posterity, I want to note that this was correct before #773; it was an oversight that this was not changed as part of this PR.
| @@ -13484,15 +13484,11 @@ <h1>Static Semantics: Contains</h1> | |||
| </emu-alg> | |||
| <emu-grammar>OptionalChain : `?.` IdentifierName</emu-grammar> | |||
| <emu-alg> | |||
| 1. If _symbol_ is a |ReservedWord|, return *false*. | |||
There was a problem hiding this comment.
Gah, thanks. I noticed this was going to happen as part of the optional chaining PR and then completely forgot about it when #1519 landed.
spec.html
Outdated
| @@ -27240,7 +27236,7 @@ <h1>Number.prototype.toExponential ( _fractionDigits_ )</h1> | |||
| 1. Return the string-concatenation of _s_ and _m_. | |||
| </emu-alg> | |||
| <emu-note> | |||
| <p>For implementations that provide more accurate conversions than required by the rules above, it is recommended that the following alternative version of step 10.b.i be used as a guideline:</p> | |||
| <p>For implementations that provide more accurate conversions than required by the rules above, it is recommended that the following alternative version of step 9.b.i be used as a guideline:</p> | |||
There was a problem hiding this comment.
Note to self: tc39/ecmarkup#192 needs addressing so this can't happen.
There was a problem hiding this comment.
See also: tc39/ecmarkdown#56
ljharb
approved these changes
Jun 15, 2020
PR tc39#773 introduced |NotEscapeSequence|, whose TV is *undefined*. Thus, in the List returned by TemplateStrings with _raw_ == *false*, any element might be *undefined*. In GetTemplateObject(), `_cookedStrings_` gets this List, so when its elements are later extracted via `_cookedStrings_[_index_]`, the "inline assertion" of `the String value` no longer applies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for recent and not-that-recent merges.