Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Complete standard preambles for numeric methods #1974

Merged
merged 1 commit into from
May 10, 2020
Merged

Editorial: Complete standard preambles for numeric methods #1974

merged 1 commit into from
May 10, 2020

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Apr 27, 2020

(This is a follow-up to #1953, which was a follow-up to #1914.)

This PR ensures that every numeric method (Number::foo and BigInt::foo) has a preamble that is in the standard form.

  • The first 4 commits deal with the 6 Number methods that have non-standard preambles (exponentiate, multiply, divide, remainder, add, subtract):
    • Commits 1-3 move out some wording that I don't think belongs in the preambles.
    • Commit 4 converts what's left to standard form.
  • Commit 5 goes to every numeric method that doesn't have a preamble, and adds a standard one.

@michaelficarra michaelficarra mentioned this pull request May 10, 2020
Open
@michaelficarra michaelficarra requested review from a team, ljharb and syg May 10, 2020 01:32
@jmdyck @ljharb
Editorial: Complete standard preambles for numeric methods (tc39#1974)
e38ce06 
 - Move talk of operators out of Number methods, down to where we actually have operators
 - Move commutative/associative sentences to Notes for Number::multiply and Number::add, just because a Note seems like a better place
 - Convert Number::subtract's prose into an emu-alg
 - Convert the preambles of 6 Number methods - to the 'standard' form introduced in PR tc39#1914.
 - Add standard preambles for numeric methods that don't have one

(For the non-prescribed part of the standard preamble, I mostly tried to re-use the wording in the existing preamble. This could probably be made more consistent between the different operations, but that wasn't my goal)
@ljharb ljharb merged commit e38ce06 into tc39:master May 10, 2020
@jmdyck jmdyck deleted the preambles branch May 10, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@ljharb ljharb ljharb approved these changes

@syg syg Awaiting requested review from syg

Assignees
No one assigned
Labels
editorial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmdyck @ljharb @michaelficarra @bakkot