Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Prevent JSON.stringify from returning ill-formed Unicode strings #1396

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Normative: Prevent JSON.stringify from returning ill-formed Unicode strings #1396

merged 1 commit into from
Feb 20, 2019

Conversation

gibson042
Copy link
Contributor

This implements https://github.com/tc39/proposal-well-formed-stringify , currently at stage 3. Tests have already been merged.
Fixes #944

@mathiasbynens mathiasbynens mentioned this pull request Jan 8, 2019
Closed
@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Jan 8, 2019
ljharb
ljharb previously requested changes Jan 8, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating the commit to match our conventions? Specifically, start it with "Normative: "

@ljharb ljharb requested review from bterlson, zenparsing and a team January 8, 2019 21:30
@gibson042 gibson042 force-pushed the proposal-well-formed-stringify branch from dcf7eb1 to 2004447 Compare January 8, 2019 21:36
@gibson042 gibson042 changed the title Prevent JSON.stringify from returning ill-formed Unicode strings Normative: Prevent JSON.stringify from returning ill-formed Unicode strings Jan 8, 2019
@gibson042
Copy link
Contributor Author

Done.

@ljharb ljharb dismissed their stale review January 8, 2019 21:40

commit convention fixed

@ljharb ljharb added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Jan 29, 2019
@targos targos mentioned this pull request Jan 30, 2019
Closed
14 tasks
@ljharb ljharb added the es2019 label Feb 10, 2019
@bterlson bterlson merged commit 7428c89 into tc39:master Feb 20, 2019
@jmdyck jmdyck mentioned this pull request Feb 25, 2019
Merged
@gsnedders gsnedders mentioned this pull request Oct 15, 2019
Open
@ljharb ljharb mentioned this pull request Aug 10, 2020
Closed
@jmdyck jmdyck mentioned this pull request Apr 15, 2021
Open
@dominikg dominikg mentioned this pull request Feb 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenparsing zenparsing zenparsing approved these changes

@bterlson bterlson bterlson approved these changes

@ljharb ljharb ljharb left review comments

Assignees

@bterlson bterlson

Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gibson042 @bterlson @ljharb @zenparsing