Editorial: Correct and make readable for-in/of/await-of static semantics #1284
Conversation
There was a problem hiding this comment.
several children have duplicated definition of VarScopedDeclarations
Not "several", but one RHS (for await ( var ForBinding of ...) has two conflicting definitions. This is clearly an editorial mistake, but I'm not certain if the fix qualifies as editorial, since an implementation that happened to follow the wrong definition would now have to change their code. (But hopefully test262 has tests that only admit the correct choice.)
The first commit eliminates the first of the conflicting definitions, which looks like the correct fix to me. However, the commit somewhat obscures that fix by also moving a different RHS from one group to another. It would be clearer to accomplish that move in the second commit. Also, the commit message should maybe be more specific about what it's fixing.
The second commit merges groups that have the same algorithm, which is purely editorial, and should indeed improve readability. However, in a multi-RHS production, I think we normally put the RHSs in the same order as they appear in the defining production.
while some have none.
No, I don't think any RHSs are missing. ( If you're thinking of the for(;;) RHSs, they're handled separately in 13.7.4.)
TimothyGu
force-pushed
the
iteration-editorial
branch
from
86aab89 to
007386c
Compare
Indeed. Commit message fixed.
I'll let the editors decide on this, but my belief is that it is editorial.
Done.
Commit message has been changed. |
…emantic for IterationStatement (tc39#1284) Currently, VarScopedDeclarations is defined for IterationStatement : `for` `await` `(` `var` ForBinding `of` AssignmentExpression `)` Statement in two different places with conflicting definitions. Remove the incorrect definition.
Coalesce children of `for`-`in`, `for`-`of`, and `for`-`await`-`of` statements with identical definitions for VarDeclaredNames and VarScopedDeclarations for better readability: instead of having six different algorithm blocks for each of VarDeclaredNames and VarScopedDeclarations now there are only two.
syg
force-pushed
the
iteration-editorial
branch
from
007386c to
fa8e6b3
Compare
First commit:
Currently, VarScopedDeclarations is defined for
in two different places with conflicting definitions. Remove the incorrect definition.
Second commit:
Coalesce children of
for-in,for-of, andfor-await-ofstatements with identical definitions for VarDeclaredNames and VarScopedDeclarations for better readability: instead of having six different algorithm blocks for each of VarDeclaredNames and VarScopedDeclarations now there are only two for each.