Normative: add Object.fromEntries
#1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
needs test262 tests
ljharb
requested review from
bterlson,
mattijs,
michaelficarra,
bmeck and
bakkot
ljharb
added
the
normative change
14 tasks
bakkot
requested changes
Jul 25, 2018
spec.html
Outdated
| @@ -24069,6 +24069,34 @@ <h1>Object.defineProperty ( _O_, _P_, _Attributes_ )</h1> | |||
| </emu-alg> | |||
| </emu-clause> | |||
|
|
|||
| <emu-clause id="sec-Object.fromEntries"> | |||
There was a problem hiding this comment.
To match the rest of the spec, I think this should be spelled sec-object.fromentries. Existing sections are
<emu-clause id="sec-object.assign">
<emu-clause id="sec-object.create">
<emu-clause id="sec-object.defineproperties">
<emu-clause id="sec-object.defineproperty">
<emu-clause id="sec-object.entries">
<emu-clause id="sec-object.freeze">
<emu-clause id="sec-object.getownpropertydescriptor">
<emu-clause id="sec-object.getownpropertydescriptors">
<emu-clause id="sec-object.getownpropertynames">
<emu-clause id="sec-object.getownpropertysymbols">
<emu-clause id="sec-object.getprototypeof">
<emu-clause id="sec-object.is">
<emu-clause id="sec-object.isextensible">
<emu-clause id="sec-object.isfrozen">
<emu-clause id="sec-object.issealed">
<emu-clause id="sec-object.keys">
<emu-clause id="sec-object.preventextensions">
<emu-clause id="sec-object.prototype">
<emu-clause id="sec-object.seal">
<emu-clause id="sec-object.setprototypeof">
<emu-clause id="sec-object.values">
<emu-clause id="sec-object.prototype.constructor">
<emu-clause id="sec-object.prototype.hasownproperty">
<emu-clause id="sec-object.prototype.isprototypeof">
<emu-clause id="sec-object.prototype.propertyisenumerable">
<emu-clause id="sec-object.prototype.tolocalestring">
<emu-clause id="sec-object.prototype.tostring">
<emu-clause id="sec-object.prototype.valueof">
ljharb
added a commit
to tc39/proposal-object-from-entries
that referenced
this pull request
Jul 25, 2018
ljharb
force-pushed
the
object-from-entries
branch
from
1ad834a to
6a744da
Compare
|
@bakkot merged into the proposal; updated here |
bakkot
approved these changes
Aug 9, 2018
ljharb
force-pushed
the
object-from-entries
branch
from
6a744da to
b7a0262
Compare
bakkot
removed
the
needs test262 tests
|
Tests landed. |
ljharb
requested review from
zenparsing
and removed request for
crookedneighbor
bterlson
approved these changes
Jan 25, 2019
ljharb
added
has stage 4
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Object.fromEntriesto the spec.It is currently stage 3; and still needs merged test262 tests, and consensus, to reach stage 4 and be merged here.
Closes tc39/proposal-object-from-entries#21.