Normative: Remove detached array buffer check prior to calling CloneArrayBuffer #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrayBuffer This aligns the detached array buffer checks in step 18 and 19 of 22.2.4.3. Fixes tc39#1002
|
It looks like this only affects the ordering of detached buffer errors and errors from running out of memory. Is that right? If so, this seems like a good idea. If I'm understanding things right, this would be pretty difficult to write a reliable test for (which size buffer will run out of memory when you clone it?) so I think we should waive the testing requirement here. |
|
I can create a test for test262 based on the example code in #1002. |
anba
added a commit
to anba/test262
that referenced
this pull request
Sep 25, 2017
|
Is there anything holding back this PR landing? |
|
The change is also implemented in Firefox Nightly and will ship in Firefox 60 (https://bugzilla.mozilla.org/show_bug.cgi?id=1423878). |
ljharb
approved these changes
Mar 5, 2018
ljharb
added
the
normative change
bterlson
approved these changes
Jul 18, 2018
ljharb
force-pushed
the
detached-arraybuffer-typedarray-ctor
branch
from
14fc9d4 to
d0d31dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the detached array buffer checks in step 18 and 19 of 22.2.4.3.
Fixes #1002