Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberBitwiseOp is imprecise with the operation it performs #2002

Closed
michaelficarra opened this issue May 20, 2020 · 0 comments · Fixed by #2004
Closed

NumberBitwiseOp is imprecise with the operation it performs #2002

michaelficarra opened this issue May 20, 2020 · 0 comments · Fixed by #2004
Labels
needs editorial changes

Comments

@michaelficarra
Copy link
Member

michaelficarra commented May 20, 2020 •
edited
Loading

NumberBitwiseOp is passed op, a sequence of code points, one of &, ^, or |. It then says

Return the result of applying the bitwise operator op to lnum and rnum.

Nowhere does it associate those sequences of code points with bitwise operations. We should be explicit about this similar to what we do in 12.15.5.

This all also applies to ByteListBitwiseOp.
@michaelficarra michaelficarra mentioned this issue May 20, 2020
Merged
michaelficarra added a commit to michaelficarra/ecma262 that referenced this issue May 21, 2020
@michaelficarra
fixes tc39#2002: more precise def. of NumberBitwiseOp and ByteListBit…
1cf3238 
…wiseOp
@michaelficarra michaelficarra mentioned this issue May 21, 2020
Merged
ljharb pushed a commit to michaelficarra/ecma262 that referenced this issue May 21, 2020
@michaelficarra @ljharb
Editorial: more precise def. of NumberBitwiseOp and ByteListBitwiseOp
e4a7295 
Fixes tc39#2002.
ljharb pushed a commit to michaelficarra/ecma262 that referenced this issue May 21, 2020
@michaelficarra @ljharb
Editorial: more precise def. of NumberBitwiseOp and ByteListBitwiseOp (…
6b6084c 
…tc39#2004)

Fixes tc39#2002.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs editorial changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #2002: more precise definition of NumberBitwiseOp and ByteListBitwiseOp michaelficarra/ecma262
2 participants
@ljharb @michaelficarra