Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing "On" while already rotating borks rotation #14

Open
travisby opened this issue Jun 21, 2013 · 0 comments
Open

Pressing "On" while already rotating borks rotation #14

travisby opened this issue Jun 21, 2013 · 0 comments

Comments

@travisby
Copy link

If you are currently rotating, and press "on", rotation will speed up, and you will be unable to ever successfully stop it again.
travisby added a commit to travisby/thingiview.js that referenced this issue Jun 21, 2013
@travisby
Fixed tbuser#14. Solved a rotation issue
9b16b95 
The interval-timer for rotation was getting overwriten,
rather than cleared.  We were losing the handle to the
first rotation instance.

We solved this issue by unconditionally clearing the
interval, and then checking whether we are starting
or stopping.
@travisby travisby mentioned this issue Jun 21, 2013
Closed
iXce added a commit to iXce/thingiview.js that referenced this issue Aug 23, 2013
@iXce
Include fix for tbuser#14
818d367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solved a rotation issue where we were losing the original interval PID travisby/thingiview.js
1 participant
@travisby