Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints #18

Merged
merged 35 commits into from
Feb 10, 2024
Merged

Add type hints #18

merged 35 commits into from
Feb 10, 2024

Conversation

tbrlpld
Copy link
Owner

@tbrlpld tbrlpld commented Feb 6, 2024 •
edited
Loading

Description

Checklist

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (111dddf) 100.00% compared to head (98df83e) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        13    +1     
  Lines          212       233   +21     
=========================================
+ Hits           212       233   +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tbrlpld added 29 commits February 10, 2024 09:24
@tbrlpld
Add mypy as dev dependency
8a47a09
@tbrlpld
Add django-stubs
a0dbc87
@tbrlpld
Configure django-stubs
7b1d2ea
@tbrlpld
Default to checking all files in the repo
fad7852
@tbrlpld
Fix import location of conditional_escape
1075ce3
@tbrlpld
Update Media and MediaDefiningClass import location
d9326fd 
Use the original source.
@tbrlpld
Use more concrete type
80c7844 
Looks like MutableMapping was not well understood.
@tbrlpld
Declare template_name property
39cee94
@tbrlpld
Update SafeString import source
8de1629
@tbrlpld
Enable mypy strict mode
27762d3
@tbrlpld
Fix annytations in testmanage.py
ccf1c93
@tbrlpld
Add type hint for memebers of MediaContainer
60a61f3
@tbrlpld
Add type hints to templatetag module
faa4888
@tbrlpld
Fix type annotations for Python 3.8
ac4a782
@tbrlpld
Move protocols to separate module
f3f9440 
Also only import what is needed at runtime.
@tbrlpld
Add return types to tests
d706241
@tbrlpld
Fix function signatures
e875a3d
@tbrlpld
Add type hint for media property
0d249b6
@tbrlpld
Use Media.__repr__ for equality assertion
f5498c5 
This does not rely on private properties and feels more readable.
@tbrlpld
Use module-level imports to avoid name conflict
c990aba
@tbrlpld
Annotate copying mock call method
426e0b4
@tbrlpld
Add return types
1ef3f1d
@tbrlpld
Make method a mock with override instead of assignment
ae8b02a 
This is simpler and seems to go better with mypy.
@tbrlpld
Add missing function signatures
308fb07
@tbrlpld
Add type hints to example components
0915844
@tbrlpld
Annotate view function
0f7974a
@tbrlpld
Annotate test functions
124969d
@tbrlpld
Add mypy pre-commit hook
8d56158
@tbrlpld
Add requests type anotations to enable mypy on all files
5816e1d
@tbrlpld tbrlpld marked this pull request as ready for review February 10, 2024 20:17
@tbrlpld tbrlpld merged commit 631884e into main Feb 10, 2024
8 checks passed
@tbrlpld tbrlpld deleted the add-type-hints branch February 10, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tbrlpld