use StarExpr in FUNC(*)

this is the only useful (?) part of my attempts at cockroachdb#1810.
tbg · Jul 26, 2015 · 178858d · 178858d
1 parent cdd21fd
commit 178858d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/sql/delete.go b/sql/delete.go
@@ -36,7 +36,7 @@ func (p *planner) Delete(n *parser.Delete) (planNode, error) {
 	// deleting.
 	node, err := p.Select(&parser.Select{
 		Exprs: parser.SelectExprs{
-			&parser.StarExpr{TableName: parser.Name(tableDesc.Name)},
+			&parser.StarExpr{TableName: parser.QualifiedName{tableDesc.Name}},
 		},
 		From:  parser.TableExprs{n.Table},
 		Where: n.Where,

diff --git a/sql/parser/select.go b/sql/parser/select.go
@@ -95,12 +95,13 @@ func (*NonStarExpr) selectExpr() {}
 // TODO(tschottdorf): needs work, see #1810. TableName is never even referenced
 // in the grammar so far.
 type StarExpr struct {
-	TableName Name
+	Expr
+	TableName QualifiedName
 }
 
 func (node *StarExpr) String() string {
 	var buf bytes.Buffer
-	if node.TableName != "" {
+	if len(node.TableName) != 0 {
 		fmt.Fprintf(&buf, "%s.", node.TableName)
 	}
 	fmt.Fprintf(&buf, "*")

diff --git a/sql/parser/sql.go b/sql/parser/sql.go
diff --git a/sql/parser/sql.y b/sql/parser/sql.y
@@ -2938,7 +2938,7 @@ func_application:
   }
 | func_name '(' '*' ')'
   {
-    $$ = &FuncExpr{Name: $1, Exprs: Exprs{QualifiedName{"*"}}}
+    $$ = &FuncExpr{Name: $1, Exprs: Exprs{&StarExpr{}}}
   }
 
 // func_expr and its cousin func_expr_windowless are split out from c_expr just