-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest Eclipse JDT Core v3.23 to enable JDK 14 source #5
Comments
@tazmaniax congratulations if you could fix the regression caused by the use of the latest JDT Core libs ! |
@tomparle I had to fix an issue with Faster GT's call to the Eclipse compiler - Faster GT wasn't really adhering to the contract, e.g. isPackage() callback was returning true for a type - see https://github.com/tazmaniax/gt-engine/pull/3/files#diff-4f393856c12e8e0f37b20d441da7916156124f6989392450151a81822b8feffa - and earlier versions of the Eclipse compiler didn't really care. Anyway now Faster GT will work for current Eclipse JDT Core versions > 18! |
@tazmaniax ho, that's what I was talking about ! |
@tomparle right, it's not the proper fix but that would have been a big effort and probably for the most part is not required. At the very least we now know where the issue is if it raises its head again. |
…1338) * #5: Update to latest Eclipse JDT Core v3.23 to enable JDK 14 source Task-Url: tazmaniax#5 * #5: Updated Groovy to v3.0.6 Task-Url: tazmaniax#5 * 5: Replace LinkedList with Collection Task-Url: tazmaniax#5 * Remove old versions of groovy * Replace reflection based approach to adding compiler phase operation * Fix groovy template compilation test A change between Groovy 3.0.4 and 3.0.5 resulted in a change in the compiler output message * Updated a few dependencies Not strictly part of this change but while there is an opportunity :)
…JDK 14 source Task-Url: tazmaniax#5 * playframework#5: Updated Groovy to v3.0.6 Task-Url: tazmaniax#5 * 5: Replace LinkedList with Collection Task-Url: tazmaniax#5 * Remove old versions of groovy * Replace reflection based approach to adding compiler phase operation * Fix groovy template compilation test A change between Groovy 3.0.4 and 3.0.5 resulted in a change in the compiler output message * Updated a few dependencies Not strictly part of this change but while there is an opportunity :)
…JDK 14 source Task-Url: tazmaniax#5 * playframework#5: Updated Groovy to v3.0.6 Task-Url: tazmaniax#5 * 5: Replace LinkedList with Collection Task-Url: tazmaniax#5 * Remove old versions of groovy * Replace reflection based approach to adding compiler phase operation * Fix groovy template compilation test A change between Groovy 3.0.4 and 3.0.5 resulted in a change in the compiler output message * Updated a few dependencies Not strictly part of this change but while there is an opportunity :)
No description provided.
The text was updated successfully, but these errors were encountered: