Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add include_image macro #9959

Merged
merged 18 commits into from
Jun 6, 2024
Merged

feat(core): add include_image macro #9959

merged 18 commits into from
Jun 6, 2024

Conversation

Legend-Master
Copy link
Contributor

Closes #9947

amrbashir
amrbashir requested changes Jun 4, 2024
View reviewed changes
core/tauri-macros/src/lib.rs Outdated Show resolved Hide resolved
core/tauri-macros/src/lib.rs Outdated Show resolved Hide resolved
core/tauri-macros/src/lib.rs Show resolved Hide resolved
core/tauri-macros/src/lib.rs Outdated Show resolved Hide resolved
core/tauri-codegen/src/context.rs Outdated Show resolved Hide resolved
@Legend-Master Legend-Master marked this pull request as ready for review June 5, 2024 05:41
@Legend-Master Legend-Master requested a review from a team as a code owner June 5, 2024 05:41
amrbashir
amrbashir requested changes Jun 6, 2024
View reviewed changes
core/tauri-macros/src/lib.rs Outdated Show resolved Hide resolved
core/tauri-macros/src/lib.rs Outdated Show resolved Hide resolved
core/tauri-macros/src/lib.rs Outdated Show resolved Hide resolved
core/tauri-macros/src/lib.rs Show resolved Hide resolved
core/tauri-codegen/src/context.rs Outdated Show resolved Hide resolved
core/tauri-codegen/src/image.rs Outdated Show resolved Hide resolved
core/tauri-codegen/src/image.rs Outdated Show resolved Hide resolved
@Legend-Master Legend-Master requested a review from amrbashir June 6, 2024 01:48
amrbashir
amrbashir reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things and this should be good to go, I am excited for this macro.

.changes/include-image-macro.md Outdated Show resolved Hide resolved
.changes/include-image-macro.md Outdated Show resolved Hide resolved
core/tauri-codegen/src/context.rs Outdated Show resolved Hide resolved
core/tauri-codegen/src/embedded_assets.rs Outdated Show resolved Hide resolved
.changes/include-image-macro.md Outdated Show resolved Hide resolved
@amrbashir amrbashir changed the title feat: add a macro to help using image from rust api directly feat(core): add include_image macro Jun 6, 2024
@amrbashir amrbashir merged commit 5b76994 into tauri-apps:dev Jun 6, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Merged
pewsheen pushed a commit to pewsheen/tauri that referenced this pull request Jun 13, 2024
@Legend-Master @pewsheen
feat(core): add include_image macro (tauri-apps#9959)
ca463b3
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] add a macro to help using image as tray icon from rust api directly
2 participants
@Legend-Master @amrbashir