Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/shell): speedup Command.execute & fix extra new lines #9796

Merged
merged 4 commits into from
May 24, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented May 15, 2024

Re-add of #9706 but with a minor release

The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events.

The extra new lines was a regression from #6519

ref: #7684 (comment)

amrbashir and others added 3 commits May 16, 2024 02:40
* fix(core/shell): speedup `Command.execute` & fix extra new lines

The speed gains comes from running the Command in Rust fully and returning the result in one go instead of using events.

The extra new lines was a regression from #6519

ref: #7684 (comment)

* fix unix build

* clippy

* cleanup

---------

Co-authored-by: Lucas Nogueira <[email protected]>
@amrbashir amrbashir requested a review from a team as a code owner May 15, 2024 23:42
@amrbashir amrbashir changed the title fix(core/shell): speedup Command.execute & fix extra new lines (#9706) fix(core/shell): speedup Command.execute & fix extra new lines May 15, 2024
lucasfernog
lucasfernog previously approved these changes May 24, 2024
@lucasfernog lucasfernog merged commit 44e3335 into 1.x May 24, 2024
32 checks passed
@lucasfernog lucasfernog deleted the feat/shell/command-speed branch May 24, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants