feat: Add support for deep links #8680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FabianLars thanks mate, a lot of Tauri apps would benefit from this! |
amrbashir
requested changes
Jan 29, 2024
|
i guess i'm the only one with vscode's auto formatter enabled lol. i'll try to revert that shit |
Co-authored-by: Amr Bashir <[email protected]>
Co-authored-by: Amr Bashir <[email protected]>
amrbashir
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with tauri-apps/plugins-workspace#916 this will resolve #323.
One semi major question we never clearly answered is how we want to align it with the file association feature. If we plan to add helper apis to the file assocs to make handling os differences easier i think it makes sense to pull that out into it's own plugin. I thought we have code apis for it, which is why i always talked about the app module, but seems like i was wrong. In this case moving it into a plugin could be done later in a non breaking way too, we'd just have 2 duplicate config entries 🤷
I just feel like they are similar enough that it may be a bit weird having one in core and one as a plugin but maybe i'm overthinking it idk.
Also, after we got v2 to stable i'd like to work on the plugin/cli instructions thingy to get rid of the plugin specific stuff again.
Speaking of that, this PR also adds xdg-open if the shell plugin is used.