Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add arch support for loong64 #8623

Closed
wants to merge 1 commit into from
Closed

Conversation

Kiri2002
Copy link

No description provided.

@Kiri2002 Kiri2002 requested a review from a team as a code owner January 17, 2024 03:27
@Kiri2002
Copy link
Author

since the loong64 already support the basic tool-chains and rust etc.
I try to simply add the ''loongarch64-unknown-linux-gnu" to the target.
Magically, works well.
From archlinux(for loong64)

@lucasfernog
Copy link
Member

This only adds documentation for the loongarch64-unknown-linux-gnu target. It doesn't change anything about how the crate is compiled. Actually compiling it is a little more complicated since you need to cross compile.

Since we don't have any particular documentation item specific to loongarch64-unknown-linux-gnu, I'll close this one. Thank you!

@Kiri2002
Copy link
Author

Kiri2002 commented Apr 25, 2024

This only adds documentation for the loongarch64-unknown-linux-gnu target. It doesn't change anything about how the crate is compiled. Actually compiling it is a little more complicated since you need to cross compile.

Since we don't have any particular documentation item specific to loongarch64-unknown-linux-gnu, I'll close this one. Thank you!

It works because rust is already support loong64. Once added loongarch64-unknown-linux-gnu target, it can be complied in loong64 machines. It doesn't need to have loong64 release in github, just for source code support, so downstream(Archlinux etc.) can compile without add patch.

Tauri is already compiled successfully in loong64.

We don't need "need to cross compile", we just compile in loong64 machine.

If it can be merged, just for source code, and don't need release compile, it will help a lot!

@Kiri2002
Copy link
Author

@lucasfernog Thank your review. I test again just now to build cargo-tauri in loong64(Archlinux), built and tested successfullt. The only thing I change is to add loongarch64-unknown-linux-gnu target.
cargo-tauri-1.5.9-1-loong64-build.log
cargo-tauri-1.5.9-1-loong64-check.log

Still hope it can add to source(convenient for loong64 user to build in their local)

@FabianLars
Copy link
Member

I am still not sure what you want us to do here to be honest. This PR only added this target to the docs.rs instructions, so that it shows up in this dropdown:
grafik
This does not change anything about the actual platform support and the docs will be exactly the same as in the already existing x86_64-unknown-linux-gnu target docs.

To give you another example, even though the docs.rs targets only include x86_64, you can compile tauri to 32bit targets and even arm (aarch64).

@Kiri2002
Copy link
Author

Kiri2002 commented Apr 30, 2024

I am still not sure what you want us to do here to be honest. This PR only added this target to the docs.rs instructions, so that it shows up in this dropdown: grafik This does not change anything about the actual platform support and the docs will be exactly the same as in the already existing x86_64-unknown-linux-gnu target docs.

To give you another example, even though the docs.rs targets only include x86_64, you can compile tauri to 32bit targets and even arm (aarch64).

Yes, that's right, without this change, it can be built.
Now I totally understand this!
Sorry for my misunderstand before, and Thank you for your perfect explain!!

@Kiri2002 Kiri2002 deleted the patch-1 branch April 30, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants