refactor(cli): enhance plugin subcommand, closes #7749 #7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
amrbashir
commented
Oct 10, 2023
…auri-apps/tauri into refactor/cli-plugin-subcommand
lucasfernog
requested changes
Oct 11, 2023
| @@ -25,17 +28,46 @@ pub struct Cli { | |||
|
|
|||
| #[derive(Subcommand)] | |||
| enum Commands { | |||
| New(new::Options), | |||
There was a problem hiding this comment.
I prefer create instead of new what do you think?
There was a problem hiding this comment.
new is the usually the term I see in bootstrapping CLIs when you have both init and new, for example, cargo new and cargo init (I honestly can't think of another example, but I am quite certain I saw it somewhere else)
There was a problem hiding this comment.
sold me on the cargo example
lucasfernog
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information