Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance the descriptions of CLI commands, closes #7572 #7952

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Oct 4, 2023

ref: #7756

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner October 4, 2023 00:31
.changes/cli-plugin-add.md Outdated Show resolved Hide resolved
@FabianLars
Copy link
Member

I like the new descriptions but why was plugin add added back?

@amrbashir
Copy link
Member Author

it is just an alias for, tauri add, and I felt like it belongs under plugin subcommand as well, but could be removed, it is just a suggestion.

@FabianLars
Copy link
Member

yeah so the reason was simply that all the other plugin commands operate on a plugin level/project while the add command operates on an actual tauri app so we felt like it could be confusing.

For ref, i think this was the discord convo about this: https://discord.com/channels/616186924390023171/986184094050316358/1138159565775569018

@amrbashir
Copy link
Member Author

amrbashir commented Oct 4, 2023

thanks for the context, will revert it then

tooling/cli/src/completions.rs Outdated Show resolved Hide resolved
tooling/cli/src/init.rs Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 2fe8782 into dev Oct 16, 2023
@lucasfernog lucasfernog deleted the refactor/cli-descriptions branch October 16, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

4 participants