Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tauri): impl Send for app::Builder, closes #7618 #7619

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

yydcnjjw
Copy link
Contributor

@yydcnjjw yydcnjjw commented Aug 15, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

closes #7618

@yydcnjjw yydcnjjw requested a review from a team as a code owner August 15, 2023 06:05
@yydcnjjw yydcnjjw changed the title feat(tauri): impl Send for app::Builder feat(tauri): impl Send for app::Builder, closes #7618 Aug 15, 2023
amrbashir
amrbashir previously approved these changes Aug 15, 2023
@amrbashir amrbashir requested a review from lucasfernog August 15, 2023 15:43
@lucasfernog
Copy link
Member

Just missing a change file :) something like this:

.changes/app-builder-send.md

---
"tauri": patch:enhance
---

Ensure Builder is Send by requiring the menu closure to be Send.

@yydcnjjw yydcnjjw force-pushed the feat/app-builder-impl-send branch from a4dde4a to c4d5377 Compare August 16, 2023 00:54
@wusyong wusyong merged commit 8a67661 into tauri-apps:dev Aug 16, 2023
@yydcnjjw yydcnjjw deleted the feat/app-builder-impl-send branch September 8, 2023 15:01
yydcnjjw added a commit to yydcnjjw/tauri that referenced this pull request Sep 8, 2023
…i-apps#7619)

* feat(tauri): impl Send for app::Builder

* chore: add .changes/app-builder-send.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

[feat] tauri::Builder is !Send
4 participants