Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): handle npx for mobile commands, closes #7209 #7218

Merged
merged 3 commits into from
Jun 16, 2023
Merged

fix(cli): handle npx for mobile commands, closes #7209 #7218

merged 3 commits into from
Jun 16, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 15, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 15, 2023 22:55
amrbashir
amrbashir commented Jun 15, 2023
View reviewed changes
.changes/cli-npx-mobile.md Outdated Show resolved Hide resolved
@wusyong wusyong added the status: needs review A maintainer must review this code label Jun 16, 2023
@lucasfernog lucasfernog changed the base branch from next to dev June 16, 2023 15:13
@lucasfernog lucasfernog merged commit 4847b87 into dev Jun 16, 2023
@lucasfernog lucasfernog deleted the fix/cli/npx-mobile branch June 16, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
status: needs review A maintainer must review this code
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @lucasfernog @wusyong