-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli/mobile/init): skip installing already installed targets, closes #7044 #7058
Conversation
Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
--skip-targets-install
, closes #7044
@amrbashir I think it's easier if we detect installed targets instead. Let me know if you have something against it. |
It is a good addition but I still think we should provide the flag anyways. Some users may want to install only install 1 or 2 targets and the flag would allow them to do so. |
The flag sounds a little feature creep to me, I would avoid unless it's really necessary. This check is already addressing a super particular use case :D usually you'll just want everything installed for you to just run |
Ideally, |
Yeah but if there's a good way to detect instead of providing a skip flag.. 😉 |
Detection always has the possibility of missing 0.01% of users and these are the users that open github issues that will ask for a flag. I like detecting and auto fixes but at the same time I also like being in control and as tauri-cli is considered a build tool, everything it does should be configurable IMO. And I don't really consider it a feature creep since the implementation is actually simple and doesn't affect anything else. |
I tend do go with the |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information