Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multi range request #4078

Closed
wants to merge 4 commits into from

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented May 8, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

If you have any plan to support the multi range, you can close this PR freely :)

@keiya01 keiya01 requested a review from a team May 8, 2022 03:14
@keiya01 keiya01 requested a review from a team as a code owner May 8, 2022 03:14
@keiya01 keiya01 force-pushed the feat/support-multi-range branch from c3b05ec to ffd41b2 Compare June 21, 2022 23:10
@keiya01 keiya01 requested a review from a team as a code owner June 21, 2022 23:10
@keiya01 keiya01 force-pushed the feat/support-multi-range branch from 90172a8 to 25453c0 Compare June 23, 2022 11:49
@JonasKruckenberg
Copy link
Member

Your commits are not signed, so we can only merge this PR once you set that up and we have a plan on how we want to handle feature additions going forward.

@keiya01
Copy link
Member Author

keiya01 commented Jun 24, 2022

It looks like my commit is signed 👀
And is this PR not needed?
Screen Shot 2022-06-24 at 10 13 45

@lucasfernog
Copy link
Member

First of all thank you for your contribution! We did not merge it because we didn't have the resources to audit it and I also couldn't find a way to test it (I'm still not sure if this is needed, no one requested it so far). I believe Amr also implemented this on the protocol refactor so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants