Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: always check parent directory (fix #8679) #11429

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

griffi-gh
Copy link
Contributor

closes #8679

@griffi-gh griffi-gh marked this pull request as ready for review October 20, 2024 21:26
@griffi-gh griffi-gh requested a review from a team as a code owner October 20, 2024 21:26
Copy link
Contributor

github-actions bot commented Oct 21, 2024

Package Changes Through 4a04855

There are 9 changes which include tauri with minor, @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-runtime-wry with minor, tauri-macros with patch, tauri-runtime with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.3 2.1.0
tauri-utils 2.0.2 2.1.0
tauri-bundler 2.0.4 2.1.0
tauri-runtime 2.1.1 2.2.0
tauri-runtime-wry 2.1.2 2.2.0
tauri-codegen 2.0.2 2.0.3
tauri-macros 2.0.2 2.0.3
tauri-plugin 2.0.2 2.0.3
tauri-build 2.0.2 2.0.3
tauri 2.0.6 2.1.0
@tauri-apps/cli 2.0.4 2.1.0
tauri-cli 2.0.4 2.1.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir amrbashir requested a review from lucasfernog October 21, 2024 12:09
lucasfernog
lucasfernog previously approved these changes Oct 21, 2024
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be fine but i'd also like input from @tweidinger since we're no longer checking the path we're at this allows the binary/resources to be anywhere in the filesystem - as long as the resources are in ../lib/name

tweidinger
tweidinger previously approved these changes Nov 6, 2024
Copy link
Contributor

@tweidinger tweidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to not ensure the path ends with the /data/usr/bin suffix, since the initial path is derived from the executable path and I don't think we make security specific promises of the resource dir.

@lucasfernog lucasfernog dismissed stale reviews from tweidinger and themself via 90794f2 November 6, 2024 13:00
@lucasfernog lucasfernog merged commit 3781429 into tauri-apps:dev Nov 6, 2024
27 checks passed
@absassi
Copy link

absassi commented Nov 22, 2024

Thanks for the fix.
Would it be possible to backport this to V1 as well? At the moment, I can't upgrade to V2 due to #9039.

@FabianLars
Copy link
Member

Sure, it's possible and we still accept prs for v1 :)

MarielaSassi pushed a commit to MarielaSassi/tauri that referenced this pull request Dec 12, 2024
…pps#11429)

* enhance: always check parent directory (fix tauri-apps#8679)

* Update crates/tauri-utils/src/platform.rs

* add change file

* fix crate

---------

Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
@MarielaSassi
Copy link

Sure, it's possible and we still accept prs for v1 :)

Backport done, please have a look. @FabianLars
#11960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] tauri resource directory is hard-coded
6 participants