-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: always check parent directory (fix #8679) #11429
Conversation
Package Changes Through 4a04855There are 9 changes which include tauri with minor, @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-runtime-wry with minor, tauri-macros with patch, tauri-runtime with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be fine but i'd also like input from @tweidinger since we're no longer checking the path we're at this allows the binary/resources to be anywhere in the filesystem - as long as the resources are in ../lib/name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine to not ensure the path ends with the /data/usr/bin
suffix, since the initial path is derived from the executable path and I don't think we make security specific promises of the resource dir.
Thanks for the fix. |
Sure, it's possible and we still accept prs for v1 :) |
…pps#11429) * enhance: always check parent directory (fix tauri-apps#8679) * Update crates/tauri-utils/src/platform.rs * add change file * fix crate --------- Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
Backport done, please have a look. @FabianLars |
closes #8679