feat(bundler/nsis): store main binary name to be used in registry for future updates #10952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through e89819fThere are 2 changes which include tauri-bundler with minor, tauri with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
changed the title
lucasfernog
reviewed
Sep 13, 2024
| data.insert("app_exe_name", to_json(app_exe_name)); | ||
| // Note: `app_exe_name` kept around to not break custom wix templates depending on it | ||
| data.insert("app_exe_name", to_json(&app_exe_name)); | ||
| data.insert("main_binary_name", to_json(app_exe_name)); |
There was a problem hiding this comment.
are you even using this one? doesn't look like it
There was a problem hiding this comment.
yeah it was leftover from previous attempt at 497b481, it is fine to keep for now
lucasfernog
approved these changes
Sep 13, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.