Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Encoding bug in the liscense page of nsis #9031

Closed
Yuxiza opened this issue Feb 29, 2024 · 2 comments · Fixed by #10049
Closed

[bug] Encoding bug in the liscense page of nsis #9031

Yuxiza opened this issue Feb 29, 2024 · 2 comments · Fixed by #10049
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@Yuxiza
Copy link

Yuxiza commented Feb 29, 2024

Describe the bug

I'm in system language Chinese. When adding liscence file to the nsis intaller, I'm having an encoding issue in the liscense page.
This looks like an encoding conversion issue between gbk and utf-8.
53f3b2e5a07aad1c6a0695ccd95448c3
Thank you for your attention.

Reproduction

  • Set the system language to Chinese (I have not test English or otherwise yet)
  • Add some Utf-8 characters in the license file
  • bundle and run

Expected behavior

Display utf-8 characters correctly

Full tauri info output

[✔] Environment
    - OS: Windows 10.0.19045 X64
    ✔ WebView2: 122.0.2365.52
    ✔ MSVC: Visual Studio 生成工具 2022
    ✔ rustc: 1.76.0 (07dca489a 2024-02-04)
    ✔ cargo: 1.76.0 (c84b36747 2024-01-18)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.11.1
    - pnpm: 8.15.4
    - yarn: 1.22.19
    - npm: 10.2.4

[-] Packages
    - tauri [RUST]: 2.0.0-beta.8
    - tauri-build [RUST]: 2.0.0-beta.6
    - wry [RUST]: 0.37.0
    - tao [RUST]: 0.26.1
    - @tauri-apps/api : not installed!
    - @tauri-apps/cli [NPM]: 2.0.0-beta.6

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../prosit
    - devUrl: http://localhost:3001/
    - bundler: Vite

Stack trace

No response

Additional context

No response
@Yuxiza Yuxiza added status: needs triage This issue needs to triage, applied to new issues type: bug labels Feb 29, 2024
@laozl
Copy link

laozl commented Jun 12, 2024

使用带bom的utf-8格式就行了.
微信截图_20240612170745

amrbashir added a commit that referenced this issue Jun 13, 2024
@amrbashir
fix(NSIS): rewrite license file with BOM
a9e3cbf 
closes #9031

This also includes a change to NSIS bundler to use UTF8 by default
@amrbashir amrbashir mentioned this issue Jun 13, 2024
Merged
amrbashir added a commit that referenced this issue Jun 13, 2024
@amrbashir
fix(NSIS): rewrite license file with BOM (#10049)
3fd84cb 
* fix(NSIS): rewrite license file with BOM

closes #9031

This also includes a change to NSIS bundler to use UTF8 by default

* refactor and cleanup
@blizzardzheng
Copy link

blizzardzheng commented Oct 30, 2024 •
edited
Loading

how to use it in mac, like not work by only boom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(NSIS): rewrite license file with BOM tauri-apps/tauri
3 participants
@blizzardzheng @laozl @Yuxiza